Skip to content

Conversation

@HHHindawy
Copy link
Contributor

No description provided.

@HHHindawy HHHindawy requested review from a team September 27, 2023 22:02
Copy link
Contributor

@sblaurock sblaurock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, Hossam! Let's let someone else take a closer look though as I'm not as familiar with such things 😄

Thank you for this!

Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, this is looking great to me as well! 🚀

I have some minor comments.

It looks like the dropdown jumps around a bit due to images loading in for the search suggestions/products. Should we give the images or their containers a min-height to make it feel a bit less jumpy?

Also, we're surfacing product recommendations in the zero state, but we aren't showing any images. I think it's the same way in the other example we have. Do we not show images in general for zero state recommendations? 🤔

@HHHindawy
Copy link
Contributor Author

HHHindawy commented Oct 7, 2023

It looks like the dropdown jumps around a bit due to images loading in for the search suggestions/products. Should we give the images or their containers a min-height to make it feel a bit less jumpy?

Hmmm... sure, we can do that.

Also, we're surfacing product recommendations in the zero state, but we aren't showing any images. I think it's the same way in the other example we have. Do we not show images in general for zero state recommendations? 🤔

Right now, we don't show images in zero state. This needs to be implemented. I believe we have a ticket for that. If I can't find it though I'll create one 👍

Do you think we should remove the zero state from this example until we implement that? @jjl014

Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for making the changes! 🚀

@jjl014 jjl014 merged commit 451ed0a into main Oct 10, 2023
@jjl014 jjl014 deleted the psl-2716-create-a-sort-of-kitchen-sink-example-styled-full-featured branch October 10, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants