-
Notifications
You must be signed in to change notification settings - Fork 3
[psl-2716] create a full featured and styled example #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[psl-2716] create a full featured and styled example #83
Conversation
sblaurock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, Hossam! Let's let someone else take a closer look though as I'm not as familiar with such things 😄
Thank you for this!
mocca102
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jjl014
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, this is looking great to me as well! 🚀
I have some minor comments.
It looks like the dropdown jumps around a bit due to images loading in for the search suggestions/products. Should we give the images or their containers a min-height to make it feel a bit less jumpy?
Also, we're surfacing product recommendations in the zero state, but we aren't showing any images. I think it's the same way in the other example we have. Do we not show images in general for zero state recommendations? 🤔
Hmmm... sure, we can do that.
Right now, we don't show images in zero state. This needs to be implemented. I believe we have a ticket for that. If I can't find it though I'll create one 👍 Do you think we should remove the zero state from this example until we implement that? @jjl014 |
jjl014
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks for making the changes! 🚀
No description provided.