[CSL-2348] Add support for displaying count and images for search suggestions #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esezen
commented
Sep 6, 2023
…ab-testing-ui-using
stanlp1
approved these changes
Sep 18, 2023
Contributor
stanlp1
left a comment
stanlp1
left a comment
There was a problem hiding this comment.
Looks pretty good to me. Just one note about the docs.
src/constants.ts
Outdated
| - Notice how the user is presented with only short sleeved items as results. | ||
| - This is because we are filtering to the "Shirts" group`; | ||
|
|
||
| export const termsWithImagesAndCountsDescription = `Pass boolean flags for \`displaySearchSuggestionImages\` and \`displaySearchSuggestionResultCounts\` fields to display images and counts for search suggestions.`; |
Contributor
There was a problem hiding this comment.
Should we add a note here about making the fields displayable? So they won't just pass the flags and wonder why it doesn't work.
Contributor
Author
There was a problem hiding this comment.
That's a great idea. I'll update
esezen
deleted the
csl-2348-os-ui-autocomplete-add-support-for-ab-testing-ui-using
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Slack for testing details