Skip to content

Conversation

@stanlp1
Copy link
Contributor

@stanlp1 stanlp1 commented Jun 6, 2025

No description provided.

@stanlp1 stanlp1 requested a review from a team as a code owner June 6, 2025 07:20
@esezen esezen changed the title [CI-4463] Add item ids to select tracking [CI-4464] Add item ids to select tracking Jun 9, 2025
// This does not apply to custom user defined sections that aren't part of Constructor index
} else if (selectedItem.result_id) {
trackAutocompleteSelect(cioClient, selectedItem.value, {
const selectData: any = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we either properly type this or inline it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remember why I added any. Removed it.

@stanlp1 stanlp1 requested a review from esezen June 13, 2025 06:31
Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stanlp1 stanlp1 merged commit 9952cef into main Jun 18, 2025
9 of 10 checks passed
@stanlp1 stanlp1 deleted the ci-4463-pass-ids-for-select-tracking branch June 18, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants