[CI-3883] Support custom pricing for product suggestions #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustom renderItem function
esezen
requested changes
Oct 8, 2024
Contributor
esezen
left a comment
esezen
left a comment
There was a problem hiding this comment.
Thanks for working on this! The functionality works great, I left some comments about the docs
| @@ -1,3 +1,4 @@ | |||
| import React from 'react'; | |||
Contributor
There was a problem hiding this comment.
Can we update the functionStrings object under utils to make sure the actual code shows up here (instead of render_CODE)?
Co-authored-by: Enes Kutay SEZEN <eneskutaysezen@gmail.com>
Co-authored-by: Enes Kutay SEZEN <eneskutaysezen@gmail.com>
mocca102
reviewed
Oct 9, 2024
| @@ -1,3 +1,4 @@ | |||
| import React from 'react'; | |||
Contributor
There was a problem hiding this comment.
import react statement required since there's JSX on the story file
mocca102
deleted the
ci-3883-os-ui-autocomplete-support-custom-pricing-for-product
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional parameter to sections configuration for a custom
renderItemfunction