Skip to content

Add cnstrc data attributes #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add cnstrc data attributes #167

merged 1 commit into from
Sep 25, 2024

Conversation

@mocca102
Copy link
Contributor

@mocca102 mocca102 commented Sep 12, 2024

No description provided.

@mocca102 mocca102 requested a review from a team as a code owner September 12, 2024 13:24
jjl014
jjl014 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jjl014 jjl014 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I can tell! I'm able to see the data attributes come through. 👍

I don't know enough about types to comment on those changes, but they seem to make sense

@jjl014 jjl014 requested a review from a team September 25, 2024 20:16
@mocca102 mocca102 merged commit 78e6310 into main Sep 25, 2024
@mocca102 mocca102 deleted the ci-3852-os-ui-autocomplete-surface-item-data-attributes branch September 25, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjl014 jjl014 jjl014 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mocca102 @jjl014