Ci 3197 os UI autocomplete component index stories tsx add client side #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esezen
reviewed
Jun 25, 2024
| jest.resetAllMocks(); | ||
| }); | ||
|
|
||
| it.only("Throws an error even if we provide a ConstructorIO Client since it's not SSR supported", () => { |
esezen
approved these changes
Jun 25, 2024
Contributor
esezen
left a comment
esezen
left a comment
There was a problem hiding this comment.
One test seems to be failing but I believe we have a story for that, right? The test itself seems fine, the implementation needs to be updated
Contributor
Author
The tests needed to be updated on this PR. Please review the updated tests @esezen |
esezen
approved these changes
Jul 3, 2024
Contributor
esezen
left a comment
esezen
left a comment
There was a problem hiding this comment.
LGTM! You might want to rebase or merge the other branch into this since you made some changes to the other one
Base automatically changed from
ci-3559-os-ui-autocomplete-setup-jest-testing-environment
to
main
July 3, 2024 13:54
mocca102
deleted the
ci-3197-os-ui-autocomplete-component-indexstoriestsx-add-client-side
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests to cover these scenarios
When passed