Setup jest testing environment #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mocca102
commented
Jun 6, 2024
mocca102
commented
- Add jest tests github actions workflow
- Add npm dependencies
- Add jest setup and configuration
mocca102
force-pushed
the
ci-3559-os-ui-autocomplete-setup-jest-testing-environment
branch
from
76b70e5 to
2627cec
Compare
mocca102
force-pushed
the
ci-3559-os-ui-autocomplete-setup-jest-testing-environment
branch
from
2627cec to
747e914
Compare
VincentGalloro
approved these changes
Jun 25, 2024
Contributor
VincentGalloro
left a comment
VincentGalloro
left a comment
There was a problem hiding this comment.
This LGTM, if you want you can get a second 👀 on it
esezen
reviewed
Jun 25, 2024
| "error" | ||
| "error", | ||
| { | ||
| "trailingComma": "es5" |
Contributor
Author
There was a problem hiding this comment.
Linting used to fail but it's not anymore. Removing it
jest.config.js
Outdated
| { | ||
| displayName: 'server', | ||
| testEnvironment: 'node', | ||
| testMatch: ['**/**/*.server.test.(js|jsx)'], |
Contributor
There was a problem hiding this comment.
Do we care about ts/tsx file here?
| @@ -0,0 +1,8 @@ | |||
| class IntersectionObserver { | |||
Contributor
There was a problem hiding this comment.
We have failOnConsole on the Quizzes UI equivalent of this file. I don't think we have to have it but it might be useful?
https://github.com/Constructor-io/constructorio-ui-quizzes/blob/main/jest.setup.ts
Contributor
Author
There was a problem hiding this comment.
Thank you I didn't know I needed this but it will make testing easier for the other PR. Adding it
| @@ -0,0 +1,20 @@ | |||
| import React from 'react'; | |||
Contributor
There was a problem hiding this comment.
Not a big deal but why jsx and not tsx?
mocca102
deleted the
ci-3559-os-ui-autocomplete-setup-jest-testing-environment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.