[CSL-3053] Zero state recommendations a/b support

[stanlp1]

No description provided.

[stanlp1]

Not too sure I like what I'm doing here.

[kwekke]

there could be side effects when setting activeSections.length = 0 since it modifies the original array. you might want to have immutability for cleaner and predictable code.

consider this scenario

const sections = [a,b,c];
console.log(sections) // prints [a,b,c] 
const {...} = useSections(query, cioClient, sections);
// it runs `activeSections.length = 0`
console.log(sections) /// prints [] 

off the top of my head, you could instead do

const [activeSections, setActiveSections] = useState(zeroStateActiveSections ? zeroStateSections : sections);
useEffect(() => {
  // Delete active sections if feature toggle, zeroStateActiveSessions is present
  if (...) {
    setActiveSections([]);
  }
}, [zeroStateActiveSections, podsData, getSearchSuggestionFeatures])

[stanlp1]

Thanks, that definitely conforms to the react pattern better.

[esezen]

This is looking good. I left a few comments, let me know what you think

[esezen]

LGTM! I think the tests are failing because we have the feature toggle on. Can you turn the toggle of and run tests on the PR before you merge?