Skip to content

[NO-CSL] Update fully featured example styles #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2024
Merged

[NO-CSL] Update fully featured example styles #124

merged 1 commit into from
Jan 5, 2024

Conversation

@esezen
Copy link
Contributor

@esezen esezen commented Jan 5, 2024

No description provided.

@esezen esezen marked this pull request as ready for review January 5, 2024 01:42
@esezen esezen requested a review from a team January 5, 2024 01:43
stanlp1
stanlp1 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@stanlp1 stanlp1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change lgtm.

I noticed that after the section name changes in the other PR, we now add classNames with spaces in them. Is this intentional/does it matter?

Screenshot 2024-01-04 at 11 24 07 PM

@esezen esezen merged commit e771e5e into main Jan 5, 2024
@esezen esezen deleted the nocsl-fix-example-styles branch January 5, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stanlp1 stanlp1 stanlp1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@esezen @stanlp1