Skip to content

Conversation

@mocca102
Copy link
Contributor

onSubmit event takes a union type as a parameter. Requiring that you add type guards before accessing any of the event object properties. Since this is a very common event. This PR Adds those type predicates with usage examples

@mocca102 mocca102 requested a review from a team December 26, 2023 19:11
Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mocca102 mocca102 merged commit 3504c23 into main Jan 3, 2024
@mocca102 mocca102 deleted the nocsl-add-type-predicates-for-submit-event branch January 3, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants