Skip to content

Explicitly export types path in package.json exports so it can be resolved #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

Explicitly export types path in package.json exports so it can be resolved #119

merged 1 commit into from
Dec 21, 2023

Conversation

@mocca102
Copy link
Contributor

@mocca102 mocca102 commented Dec 21, 2023

To reproduce the error that was caused by the absence of this

  • npx create-next-app@latest
  • cd your-app
  • npm i @constructor-io/constructorio-ui-autocomplete
  • Create a component and paste in the following snippet (in thread)
  • Observe error in ticket in import statement for useCioAutocomplete

@mocca102 mocca102 requested a review from a team December 21, 2023 14:49
esezen
esezen approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mocca102 mocca102 merged commit b3305af into main Dec 21, 2023
@mocca102 mocca102 deleted the csl-3125-os-ui-autocomplete-update-type-exports branch December 21, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esezen esezen esezen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mocca102 @esezen