Update storybook version to v7.6.6 #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esezen
requested changes
Dec 22, 2023
Contributor
esezen
left a comment
esezen
left a comment
There was a problem hiding this comment.
This is looking good 🚀 I think we should revert the type changes, let me know if you disagree
| import ConstructorIOClient from '@constructor-io/constructorio-client-javascript'; | ||
| import { CioAutocomplete } from '../../../index'; | ||
| import { CioAutocomplete, CioAutocompleteProps } from '../../../index'; | ||
| import { argTypes } from '../argTypes'; |
src/types.ts
Outdated
| export type Section = AutocompleteSection | RecommendationsSection | CustomSection; | ||
|
|
||
| export type UserDefinedSection = CustomSection | SectionConfiguration; | ||
| export type UserDefinedSection = Section; |
Contributor
There was a problem hiding this comment.
Why are we changing types on a Storybook PR? I think this is fixed in another PR already so maybe we can skip it here?
esezen
deleted the
csl-2817-autocomplete-os-ui-better-storybook-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.