[CSL-3029] Update isProduct type guard #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocca102
reviewed
Nov 13, 2023
jjl014
approved these changes
Nov 13, 2023
Contributor
jjl014
left a comment
jjl014
left a comment
There was a problem hiding this comment.
This looks great to me! 🚀
Just left one small comment.
| recommendationPodResults[pod.id] = results?.map((item: Item) => ({ | ||
| ...item, | ||
| id: item?.data?.id, | ||
| section: pod.id, |
Contributor
There was a problem hiding this comment.
Are we using the pod id for anything? If so, we might want to keep it around
Contributor
Author
|
@mocca102 Can you give this another review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isProducttype guard was broken in this PR. That PR incorrectly assumes anything outside of theProductssection would be a non-product but that assumption is not correct. Recommendations would have a different section and could have an image. This PR reverts the type guard but also makes sure anything inSearch Suggestionssection will return false.