Skip to content

[CI-3858] Resolve body with task_id on mutating items and variations functions #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
esezen merged 3 commits into from
Dec 23, 2024
Merged

[CI-3858] Resolve body with task_id on mutating items and variations functions #209

esezen merged 3 commits into from
Dec 23, 2024

Conversation

@ZSnake
Copy link
Contributor

@ZSnake ZSnake commented Sep 25, 2024 •
edited
Loading

  • Update the following mutating functions to return the API call response body instead of resolving an empty promise:
    • createOrReplaceItems
    • updateItems
    • deleteItems
    • createOrReplaceVariations
    • updateVariations
    • deleteVariations
  • Fix broken tests related to getBrowseResults and Facet Configurations cleanup hook

@ZSnake
[CI-3858] Update mutating functions for items and variations to retur…
b1df769 
…n the API call response body instead of resolving an empty promise
@jjl014 jjl014 requested a review from a team September 25, 2024 23:35
Mudaafi
Mudaafi requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Mudaafi Mudaafi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Thanks for fixing the tests. Let's also update the types in catalog.d.ts before we merge this in.

src/modules/catalog.js Outdated
signal,
});

const body = await response.json();
Copy link
Contributor

@Mudaafi Mudaafi Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move this within the conditional if (response.ok) {. If we return an error, it might not be in json so we'll resolve a json-parse error instead of the http error on line 264. Besides, that's the only place we're using body anyways.

@ZSnake ZSnake requested a review from Mudaafi October 3, 2024 15:52
Mudaafi
Mudaafi approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let's get a second review since this touches a lot of methods

@Mudaafi Mudaafi requested a review from a team October 3, 2024 17:05
stanlp1
stanlp1 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@stanlp1 stanlp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esezen esezen merged commit e8707b3 into master Dec 23, 2024
@esezen esezen deleted the CI-3858-update-items-apis-return-values branch December 23, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mudaafi Mudaafi Mudaafi approved these changes

@stanlp1 stanlp1 stanlp1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZSnake @Mudaafi @stanlp1 @esezen