Browse and Browse Items support for filter_match_type #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanlp1
approved these changes
Sep 24, 2024
| assertTrue("browse result id exists", response.getResultId() != null); | ||
| assertTrue("request exists", response.getRequest() != null); | ||
| assertTrue("browse results exist", response.getResponse().getResults().size() >= 0); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we check the request returned in the response, make sure filter_match_types is there?
jjl014
approved these changes
Oct 10, 2024
Contributor
jjl014
left a comment
jjl014
left a comment
There was a problem hiding this comment.
LGTM! 🚀 Thank you for updating the tests!
jjl014
deleted the
ci-3819-java-sdk-adding-support-for-filter_match_type-in-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filterMatchTypesKeyConstructorIOBrowseRequestBrowseRequestTestConstructorIOBrowseTestBrowseItemsRequestConstructorIOBrowseItemsTestBrowseItemsRequestTest