[CSL-2060] Utilize UI autocomplete in React example #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esezen
commented
Feb 28, 2023
src/index.css
Outdated
| max-height: 660px; | ||
| } | ||
|
|
||
| div.cio-autocomplete .cio-submit-btn, .cio-clear-btn { |
Contributor
Author
There was a problem hiding this comment.
How do we feel about the specificity of these?
Contributor
There was a problem hiding this comment.
Do we have a reason for having element selectors plus the class selectors? I tried and removed all of them and it was the same
Contributor
Author
There was a problem hiding this comment.
I was using the default styles at first and I needed the element selectors to make it specific. Now that I'm not using the default styles, I think they are unnecessary. I'll update
mocca102
approved these changes
Mar 7, 2023
src/index.css
Outdated
| max-height: 660px; | ||
| } | ||
|
|
||
| div.cio-autocomplete .cio-submit-btn, .cio-clear-btn { |
Contributor
There was a problem hiding this comment.
Do we have a reason for having element selectors plus the class selectors? I tried and removed all of them and it was the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion with Jesse, changed the product count from 6 to 8 to use the defaults of OS UI and show simplicity of implementation.