Translate flashed messages (and add one) for authentication flow #28
Conversation
docker/pythonpath/superset_config.py
Outdated
| # Extend the default AuthOAuthView to override the default message when the user is not authorized | ||
| class CustomAuthOAuthView(AuthOAuthView): | ||
| @expose("/login") | ||
| def login(self) -> WerkzeugResponse: | ||
| flash(translate("Welcome! Please sign up or log in with Auth0 below to access the application."), "info") |
There was a problem hiding this comment.
On an app I previously worked on, we realized people were confused about "sign in" vs "sign up" vs "log in" if our language didn't match exactly (by which, here, I mean "match the Auth0 button")
It was actually complicated by using a SSO provider (as we are now) which doesn't let you choose at this stage whether you will create an account vs login with an existing one; there's only one button and that confuses new users who think they don't have an account. Nothing we can do about that, but my main suggestion is to make sure the term in our flashed message matches the Auth0 button's term.
There was a problem hiding this comment.
On an app I previously worked on, we realized people were confused about "sign in" vs "sign up" vs "log in" if our language didn't match exactly (by which, here, I mean "match the Auth0 button")
Yeah, this is exactly the issue I'm trying to solve with the flashed message.
my main suggestion is to make sure the term in our flashed message matches the Auth0 button's term.
The Auth0 button says "Sign in with auth0" (and it doesn't seem like it's translatable). I thought to supplement that with the message "Welcome! Please sign up or log in with Auth0 below to access the application" which I thought provided some clarification. But word smithing welcome.
Maybe "Welcome! Please sign up or log in by pressing 'Sign in with auth0' to access the application"?
There was a problem hiding this comment.
Welcome! Please sign up or log in by pressing 'Sign in with auth0' to access the application"?
I like this one. 👍
I have observed recently that some new users are unsure of what to do when they open the Superset
/loginpage; it's not obvious to them that "Sign in with auth0" encompasses both signing up and logging in. I have therefore added a "welcome" message with helpful information about signing up or logging in to be flashed at the top of the page.In the same stroke, I have added translations for all of the messages flashed by
CustomAuth0AuthView. The translations include all of the currently supported (by us) languages in Superset - en, pt_BR, nl, es, fr.