-
Notifications
You must be signed in to change notification settings - Fork 46
Integrate FAO-WOCAT #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate FAO-WOCAT #855
Conversation
30dc02a
to
9afd0f3
Compare
@azvoleff please could you review this PR |
Thanks @Samweli. This is looking good. We do need to make a few tweaks though, primarily to allow users to use either a pre-calculated dataset or a custom dataset for FAO-WOCAT. Users need to have the ability to customize Trends.Earth and FAO-WOCAT, and also the ability to have pre-calculated options for JRC, and FAO-WOCAT (and potentially for Trends.Earth in the future though this is not yet available). So we need to change the logic here slightly, and have three radio buttons at the beggining of the tool, for "Trends.Earth land productivity", "FAO-WOCAT land productivity", and "JRC land productivity".
Also looks like there are some minor conflicts in the ui files - can you fix |
c4256a3
to
62145b5
Compare
for more information, see https://pre-commit.ci
@gdaldegan I have pushed a fix for the issue, the zip file should now work without issues. |
Thanks @Samweli! I downloaded the zipfile referent to this PR and I'm now testing it for us to discuss in our upcoming sprint call. One inconsistency I have noticed is regarding the 15y moving window for the land productivity sub-indicator. The GPG on SDG 15.3.1 says that the land productivity sub-indicator needs to be assessed over a time-series of 15 years for establishing the baseline and for subsequential periods of progresses. Thus, we need to reflect that in the GUI, making sure that land productivity respects this requirement |
🚀 Plugin Build Successful! ✅A new plugin build has been successfully generated for the changes in this pull request! 🎉 📌 Next Steps
🛠 Powered by GitHub Actions & gh API |
Since the PR was created by Samweli and is in his fork, I will merge this into a new branch in the origin repository and create another PR with the necessary changes. |
1b66c4f
into
ConservationInternational:issue_824
Fixes #824
Screenshot of the new FAO-WOCAT option in the land productivity dialog.
faowocat_productivity_ui.mp4