Skip to content

Conversation

Samweli
Copy link
Collaborator

@Samweli Samweli commented Nov 27, 2024

Fixes #824

image

Screenshot of the new FAO-WOCAT option in the land productivity dialog.

faowocat_productivity_ui.mp4

@Samweli Samweli marked this pull request as ready for review January 25, 2025 00:15
@mvmaltitz
Copy link
Collaborator

@azvoleff please could you review this PR

@azvoleff
Copy link
Contributor

azvoleff commented Feb 1, 2025

Thanks @Samweli. This is looking good. We do need to make a few tweaks though, primarily to allow users to use either a pre-calculated dataset or a custom dataset for FAO-WOCAT. Users need to have the ability to customize Trends.Earth and FAO-WOCAT, and also the ability to have pre-calculated options for JRC, and FAO-WOCAT (and potentially for Trends.Earth in the future though this is not yet available). So we need to change the logic here slightly, and have three radio buttons at the beggining of the tool, for "Trends.Earth land productivity", "FAO-WOCAT land productivity", and "JRC land productivity".

  • If a user selects Trends.Earth, they should have the ability to access the Advanced configuration tab (so same functionality as currently is in the tool.
  • If a user selects FAO-WOCAT, then they need to be able to select either "Pre-calculated dataset", or "Custom dataset". If they select "Pre-calculated dataset" then a combo box should be activated with the FAO-WOCAT pre-calculated options. If they select "Custom dataset" then the advanced configuration options that you have added should be shown.
  • If a user select FAO-WOCAT, then a combo box should be activated with the JRC pre-calculated options. There is no ability to customize the JRC datasets.

Also looks like there are some minor conflicts in the ui files - can you fix

@gdaldegan
Copy link
Contributor

got a Python Error message when trying to open the Land Productivity geoprocessing algorithm:
image

@Samweli
Copy link
Collaborator Author

Samweli commented Mar 25, 2025

got a Python Error message when trying to open the Land Productivity geoprocessing algorithm: image

@gdaldegan I have pushed a fix for the issue, the zip file should now work without issues.

@mvmaltitz mvmaltitz linked an issue Mar 25, 2025 that may be closed by this pull request
@gdaldegan
Copy link
Contributor

Thanks @Samweli! I downloaded the zipfile referent to this PR and I'm now testing it for us to discuss in our upcoming sprint call.

One inconsistency I have noticed is regarding the 15y moving window for the land productivity sub-indicator. The GPG on SDG 15.3.1 says that the land productivity sub-indicator needs to be assessed over a time-series of 15 years for establishing the baseline and for subsequential periods of progresses. Thus, we need to reflect that in the GUI, making sure that land productivity respects this requirement
image

Copy link
Contributor

🚀 Plugin Build Successful!

A new plugin build has been successfully generated for the changes in this pull request! 🎉

🔗 Download Plugin Zip 📥

📌 Next Steps

  • 📥 Download and test the plugin built from this pull request.
  • 🔄 Review the changes and validate functionality.
  • 📝 Provide feedback on this pull request!

🛠 Powered by GitHub Actions & gh API

@dimasciput dimasciput changed the base branch from main to issue_824 May 19, 2025 13:44
@dimasciput
Copy link
Collaborator

Since the PR was created by Samweli and is in his fork, I will merge this into a new branch in the origin repository and create another PR with the necessary changes.

@dimasciput dimasciput merged commit 1b66c4f into ConservationInternational:issue_824 May 19, 2025
9 checks passed
@dimasciput dimasciput mentioned this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PR artifact generation Integration with third party apps: Further integration with FAO-WOCAT. 
5 participants