Skip to content

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Oct 8, 2025

I know @rolfyone is opinionated on this, but I'd like to have more info by default when block production fails

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Update ValidatorLogger.dutyFailed to log exceptions at error level for block production and when trace is enabled, omitting exceptions otherwise.

  • Logging:
    • ValidatorLogger.dutyFailed: Adjust error logging to include the exception only when log.isTraceEnabled() or producedType == "block"; otherwise log the message without the throwable.

Written by Cursor Bugbot for commit c76e1be. This will update automatically on new commits. Configure here.

@StefanBratanov
Copy link
Contributor

LGTM from my perspective. I had to modify that piece of code for debugging so it seems sensible to enable it specifically for block production. Will leave to others for final approval and other opinions.

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just dont want it as the default all the time because we spam the hell out of our logs sometimes without thinking.

@tbenr tbenr enabled auto-merge (squash) October 10, 2025 09:33
@tbenr tbenr merged commit cb16f65 into Consensys:master Oct 10, 2025
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2025
@tbenr tbenr deleted the log-exception-on-validator-block-production-failure branch October 10, 2025 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants