Always log error exception for block production #9985
Merged
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know @rolfyone is opinionated on this, but I'd like to have more info by default when block production fails
Documentation
doc-change-required
label to this PR if updates are required.Changelog
Note
Update ValidatorLogger.dutyFailed to log exceptions at error level for block production and when trace is enabled, omitting exceptions otherwise.
ValidatorLogger.dutyFailed
: Adjust error logging to include the exception only whenlog.isTraceEnabled()
orproducedType == "block"
; otherwise log the message without the throwable.Written by Cursor Bugbot for commit c76e1be. This will update automatically on new commits. Configure here.