Add support for v1.6.0-alpha.4#9756
Merged
lucassaldanha merged 4 commits intoConsensys:masterfrom Aug 14, 2025
Merged
Conversation
Member
|
Thanks for the PR @jtraglia! We'll try to look at it and add the missing bits :) |
3 tasks
2 tasks
36445d5 to
85dfc99
Compare
Contributor
Author
|
@lucassaldanha I've rebased this PR onto @zilm13's. Let's see if the reference tests pass. If they do pass, please merge Dmitrii's PR and mark this PR as ready for review. |
lucassaldanha
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds support for the newest consensus-specs release:
There were some new SSZ tests. We can ignore the tests for progressive lists. The new
Vector[boolean, N]tests are failing though, because we don't fully support this. I spent a little bit of time trying to figure it out, but I didn't love my solution so I think it would be best to let the team fix it. Here's some relevant code:teku/eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/ssz_generic/SszGenericBasicVectorTestExecutor.java
Lines 77 to 82 in b15588c
Feel free to take over this PR & commit to the branch. Or tell me what to do and I'll make the changes.
Some of the failing tests:
An example of a failing test:
The relevant consensus-specs PRs:
Also, no security concerns with this. The only instance of
Vector[boolean, N]is in eip7732 here:Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog