Skip to content

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Jul 2, 2025

PR Description

Fix gradle deprecations and warnings

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Cloudsmith Upload Fails Due to Timing Changes

The cloudsmithUpload task's conversion to an Exec task changed the evaluation timing of distTar.archiveFile.get() and distZip.archiveFile.get() from execution time to configuration time. This can cause failures as the archive files may not be available or correctly determined during configuration. Additionally, the workingDir was explicitly set to project.rootDir, potentially breaking the cloudsmith-upload.sh script if it relies on the project directory as its working directory.

build.gradle#L1185-L1191

teku/build.gradle

Lines 1185 to 1191 in 17dfaec

task cloudsmithUpload(type: Exec) {
dependsOn([distTar, distZip])
executable project.file("scripts/cloudsmith-upload.sh").absolutePath
args rootProject.version, distTar.archiveFile.get(), distZip.archiveFile.get()
workingDir project.rootDir
}

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

@mehdi-aouadi mehdi-aouadi marked this pull request as draft July 2, 2025 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant