Post Fulu BlobSidecars RPC deprecation#9408
Merged
zilm13 merged 10 commits intoConsensys:dasfrom May 23, 2025
Merged
Conversation
jeroost
force-pushed
the
blobssidecarsbyroot-and-by-range-deprecation-support
branch
from
97f151f to
667b106
Compare
zilm13
reviewed
May 15, 2025
.../pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsByRangeMessageHandler.java
Outdated
Show resolved
Hide resolved
.../pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsByRangeMessageHandler.java
Outdated
Show resolved
Hide resolved
...pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsRpcFuluDeprecationTest.java
Show resolved
Hide resolved
...pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsRpcFuluDeprecationTest.java
Outdated
Show resolved
Hide resolved
...pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsRpcFuluDeprecationTest.java
Outdated
Show resolved
Hide resolved
...pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsRpcFuluDeprecationTest.java
Outdated
Show resolved
Hide resolved
...pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsRpcFuluDeprecationTest.java
Outdated
Show resolved
Hide resolved
...pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsRpcFuluDeprecationTest.java
Show resolved
Hide resolved
…d-by-range-deprecation-support # Conflicts: # networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsByRangeMessageHandler.java
zilm13
reviewed
May 23, 2025
| finalizedSlot, | ||
| specConfig.getMaxRequestBlobSidecars()); | ||
| if (message.getCount().isZero()) { | ||
| if (message.getCount().isZero() || !availabilityRequiredAtStart) { |
Contributor
There was a problem hiding this comment.
not sure about this.
Say, (forget about fulu) we are at epoch 5096, requested slot at epoch 999 with count 100, so we should reply with some blobSidecars starting from epoch 1000, but we will answer with empty response in this case. Also I'd cover this case with a test
Contributor
Author
There was a problem hiding this comment.
You're 100% right.
I've updated both code and added a new test for this case. Please have a look
...h/pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsByRootMessageHandler.java
Show resolved
Hide resolved
...sys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsByRangeFuluDeprecationTest.java
Outdated
Show resolved
Hide resolved
...sys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsByRangeFuluDeprecationTest.java
Outdated
Show resolved
Hide resolved
zilm13
approved these changes
May 23, 2025
Contributor
zilm13
left a comment
zilm13
left a comment
There was a problem hiding this comment.
LGTM
Thank you for your help. Great work!
2 tasks
lucassaldanha
pushed a commit
to lucassaldanha/teku
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Implement the PeerDas consensus spec change here
ethereum/consensus-specs#4286
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog