Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express seen_ttl in consensus params #8140

Merged

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Mar 25, 2024

PR Description

As per ethereum/consensus-specs#3627

I think more consistent to set with consensus params values to align with networks like Gnosis, etc rather than the hardcoded value we have at the moment:

static final Duration DEFAULT_HEARTBEAT_INTERVAL = Duration.ofMillis(700);
static final Duration DEFAULT_SEEN_TTL = DEFAULT_HEARTBEAT_INTERVAL.multipliedBy(1115);

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) March 26, 2024 08:27
@StefanBratanov StefanBratanov merged commit 9ce484a into Consensys:master Mar 26, 2024
15 checks passed
@StefanBratanov StefanBratanov deleted the seen_ttl_consensus_params branch March 26, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants