Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Obol DVT flag #8077

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Mar 14, 2024

PR Description

Rename Obol DVT flag to --Xobol-dvt-integration-enabled. This is an experimental feature.

Fixed Issue(s)

related to #6851

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

paramLabel = "<BOOLEAN>",
description =
"Use DVT endpoints to determine if a distributed validator has aggregation duties.",
arity = "0..1",
showDefaultValue = CommandLine.Help.Visibility.ALWAYS,
hidden = true,
fallbackValue = "true")
private boolean dvtSelectionsEndpointEnabled =
private boolean obolDvtSelectionsEndpointEnabled =
ValidatorConfig.DEFAULT_DVT_SELECTIONS_ENDPOINT_ENABLED;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this DEFAULT_OBOL_DVT_SELECTIONS_ENDPOINT_ENABLED too?

@lucassaldanha lucassaldanha enabled auto-merge (squash) March 14, 2024 22:15
@lucassaldanha lucassaldanha merged commit 0b6ebe5 into Consensys:master Mar 14, 2024
14 of 15 checks passed
@lucassaldanha lucassaldanha deleted the obol-dvt-flag branch July 31, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants