7390 consensus block value

data/beaconrestapi/build.gradle

@@ -38,8 +38,8 @@ dependencies {
     testImplementation testFixtures(project(':infrastructure:bls'))
     testImplementation testFixtures(project(':infrastructure:restapi'))
     testImplementation testFixtures(project(':infrastructure:time'))
-
     testImplementation testFixtures(project(':infrastructure:json'))
+    testImplementation testFixtures(project(':infrastructure:logging'))
 
     testCompileOnly 'io.libp2p:jvm-libp2p'
 

data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/AbstractDataBackedRestAPIIntegrationTest.java

@@ -41,6 +41,7 @@
 import org.junit.jupiter.api.AfterEach;
 import tech.pegasys.teku.api.DataProvider;
 import tech.pegasys.teku.api.ExecutionClientDataProvider;
+import tech.pegasys.teku.api.RewardCalculator;
 import tech.pegasys.teku.beacon.sync.SyncService;
 import tech.pegasys.teku.bls.BLSKeyGenerator;
 import tech.pegasys.teku.bls.BLSKeyPair;
@@ -134,6 +135,8 @@ public abstract class AbstractDataBackedRestAPIIntegrationTest {
   protected final ExecutionLayerBlockProductionManager executionLayerBlockProductionManager =
       mock(ExecutionLayerBlockProductionManager.class);
 
+  protected RewardCalculator rewardCalculator = mock(RewardCalculator.class);
+
   protected OperationPool<SignedBlsToExecutionChange> blsToExecutionChangePool;
 
   protected final SignedBlsToExecutionChangeValidator validator =
@@ -241,6 +244,7 @@ private void setupAndStartRestAPI(BeaconRestApiConfig config) {
             .syncCommitteeContributionPool(syncCommitteeContributionPool)
             .proposersDataManager(proposersDataManager)
             .executionLayerBlockProductionManager(executionLayerBlockProductionManager)
+            .rewardCalculator(rewardCalculator)
             .build();
 
     beaconRestApi =

data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v1/rewards/GetBlockRewardsIntegrationTest.java

@@ -21,6 +21,7 @@
 import okhttp3.Response;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import tech.pegasys.teku.api.RewardCalculator;
 import tech.pegasys.teku.beaconrestapi.AbstractDataBackedRestAPIIntegrationTest;
 import tech.pegasys.teku.beaconrestapi.handlers.v1.rewards.GetBlockRewards;
 import tech.pegasys.teku.infrastructure.json.JsonTestUtil;
@@ -37,6 +38,7 @@ public class GetBlockRewardsIntegrationTest extends AbstractDataBackedRestAPIInt
   @BeforeEach
   public void setup() {
     spec = TestSpecFactory.createMinimalAltair();
+    rewardCalculator = new RewardCalculator(spec);
     final DataStructureUtil dataStructureUtil = new DataStructureUtil(spec);
     startRestAPIAtGenesis(SpecMilestone.ALTAIR);
     chainBuilder.generateBlocksUpToSlot(10);

data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v1/rewards/GetSyncCommitteeRewardsIntegrationTest.java

@@ -26,6 +26,7 @@
 import okhttp3.Response;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import tech.pegasys.teku.api.RewardCalculator;
 import tech.pegasys.teku.api.migrated.SyncCommitteeRewardData;
 import tech.pegasys.teku.beaconrestapi.AbstractDataBackedRestAPIIntegrationTest;
 import tech.pegasys.teku.beaconrestapi.handlers.v1.rewards.GetSyncCommitteeRewards;
@@ -46,6 +47,7 @@ public class GetSyncCommitteeRewardsIntegrationTest
   @BeforeEach
   public void setup() {
     spec = TestSpecFactory.createMinimalAltair();
+    rewardCalculator = new RewardCalculator(spec);
     final DataStructureUtil dataStructureUtil = new DataStructureUtil(spec);
     startRestAPIAtGenesis(SpecMilestone.ALTAIR);
     final SyncAggregate syncAggregate =

data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v3/GetNewBlockV3IntegrationTest.java

@@ -22,6 +22,7 @@
 import static org.mockito.Mockito.when;
 import static tech.pegasys.teku.infrastructure.http.HttpStatusCodes.SC_INTERNAL_SERVER_ERROR;
 import static tech.pegasys.teku.infrastructure.http.HttpStatusCodes.SC_OK;
+import static tech.pegasys.teku.infrastructure.http.RestApiConstants.HEADER_CONSENSUS_BLOCK_VALUE;
 import static tech.pegasys.teku.infrastructure.http.RestApiConstants.HEADER_CONSENSUS_VERSION;
 import static tech.pegasys.teku.infrastructure.http.RestApiConstants.HEADER_EXECUTION_PAYLOAD_BLINDED;
 import static tech.pegasys.teku.infrastructure.http.RestApiConstants.HEADER_EXECUTION_PAYLOAD_VALUE;
@@ -40,6 +41,7 @@
 import org.apache.tuweni.units.bigints.UInt256;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.TestTemplate;
+import tech.pegasys.teku.api.migrated.BlockRewardData;
 import tech.pegasys.teku.beaconrestapi.AbstractDataBackedRestAPIIntegrationTest;
 import tech.pegasys.teku.beaconrestapi.handlers.v3.validator.GetNewBlockV3;
 import tech.pegasys.teku.bls.BLSSignature;
@@ -49,6 +51,7 @@
 import tech.pegasys.teku.spec.SpecMilestone;
 import tech.pegasys.teku.spec.TestSpecContext;
 import tech.pegasys.teku.spec.TestSpecInvocationContextProvider;
+import tech.pegasys.teku.spec.constants.EthConstants;
 import tech.pegasys.teku.spec.datastructures.blocks.BeaconBlock;
 import tech.pegasys.teku.spec.datastructures.blocks.versions.deneb.BlindedBlockContents;
 import tech.pegasys.teku.spec.datastructures.blocks.versions.deneb.BlockContents;
@@ -62,22 +65,17 @@ public class GetNewBlockV3IntegrationTest extends AbstractDataBackedRestAPIInteg
   private DataStructureUtil dataStructureUtil;
   private SpecMilestone specMilestone;
   private final UInt256 executionPayloadValue = UInt256.valueOf(12345);
+  private final UInt256 consensusBlockValue = UInt256.valueOf(123);
+
+  private final String consensusBlockValueWei =
+      EthConstants.GWEI_TO_WEI.multiply(consensusBlockValue).toDecimalString();
 
   @BeforeEach
   void setup(final TestSpecInvocationContextProvider.SpecContext specContext) {
     spec = specContext.getSpec();
     specMilestone = specContext.getSpecMilestone();
     startRestAPIAtGenesis(specMilestone);
     dataStructureUtil = new DataStructureUtil(spec);
-  }
-
-  @TestTemplate
-  void shouldGetUnBlindedBeaconBlockAsJson() throws IOException {
-    assumeThat(specMilestone).isLessThan(DENEB);
-    final BeaconBlock beaconBlock = dataStructureUtil.randomBeaconBlock(ONE);
-    final BLSSignature signature = beaconBlock.getBlock().getBody().getRandaoReveal();
-    when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
-        .thenReturn(SafeFuture.completedFuture(Optional.of(beaconBlock)));
     when(executionLayerBlockProductionManager.getCachedPayloadResult(UInt64.ONE))
         .thenReturn(
             Optional.of(
@@ -87,14 +85,20 @@ void shouldGetUnBlindedBeaconBlockAsJson() throws IOException {
                     Optional.empty(),
                     Optional.empty(),
                     Optional.of(SafeFuture.completedFuture(executionPayloadValue)))));
+    final BlockRewardData blockRewardDataMock = mock(BlockRewardData.class);
+    when(blockRewardDataMock.getTotal()).thenReturn(consensusBlockValue.toLong());
+    when(rewardCalculator.getBlockRewardData(any(), any())).thenReturn(blockRewardDataMock);
+  }
+
+  @TestTemplate
+  void shouldGetUnBlindedBeaconBlockAsJson() throws IOException {
+    assumeThat(specMilestone).isLessThan(DENEB);
+    final BeaconBlock beaconBlock = dataStructureUtil.randomBeaconBlock(ONE);
+    final BLSSignature signature = beaconBlock.getBlock().getBody().getRandaoReveal();
+    when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
+        .thenReturn(SafeFuture.completedFuture(Optional.of(beaconBlock)));
     Response response = get(signature, ContentTypes.JSON);
-    assertThat(response.code()).isEqualTo(SC_OK);
-    assertThat(response.header(HEADER_CONSENSUS_VERSION))
-        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED))
-        .isEqualTo(Boolean.toString(false));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
-        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertResponseWithHeaders(response, false);
     final String body = response.body().string();
     assertThat(body).isEqualTo(getExpectedBlockAsJson(specMilestone, false, false));
   }
@@ -106,23 +110,8 @@ void shouldGetUnblindedBeaconBlockAsSsz() throws IOException {
     final BLSSignature signature = beaconBlock.getBlock().getBody().getRandaoReveal();
     when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
         .thenReturn(SafeFuture.completedFuture(Optional.of(beaconBlock)));
-    when(executionLayerBlockProductionManager.getCachedPayloadResult(UInt64.ONE))
-        .thenReturn(
-            Optional.of(
-                new ExecutionPayloadResult(
-                    mock(ExecutionPayloadContext.class),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.of(SafeFuture.completedFuture(executionPayloadValue)))));
     Response response = get(signature, ContentTypes.OCTET_STREAM);
-    assertThat(response.code()).isEqualTo(SC_OK);
-    assertThat(response.header(HEADER_CONSENSUS_VERSION))
-        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED))
-        .isEqualTo(Boolean.toString(false));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
-        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertResponseWithHeaders(response, false);
     final BeaconBlock result =
         spec.getGenesisSchemaDefinitions()
             .getBeaconBlockSchema()
@@ -137,22 +126,8 @@ void shouldGetBlindedBeaconBlockAsJson() throws IOException {
     final BLSSignature signature = blindedBeaconBlock.getBlock().getBody().getRandaoReveal();
     when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
         .thenReturn(SafeFuture.completedFuture(Optional.of(blindedBeaconBlock)));
-    when(executionLayerBlockProductionManager.getCachedPayloadResult(UInt64.ONE))
-        .thenReturn(
-            Optional.of(
-                new ExecutionPayloadResult(
-                    mock(ExecutionPayloadContext.class),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.of(SafeFuture.completedFuture(executionPayloadValue)))));
     Response response = get(signature, ContentTypes.JSON);
-    assertThat(response.code()).isEqualTo(SC_OK);
-    assertThat(response.header(HEADER_CONSENSUS_VERSION))
-        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED)).isEqualTo(Boolean.toString(true));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
-        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertResponseWithHeaders(response, true);
     final String body = response.body().string();
     assertThat(body).isEqualTo(getExpectedBlockAsJson(specMilestone, true, false));
   }
@@ -164,22 +139,8 @@ void shouldGetBlindedBeaconBlockAsSsz() throws IOException {
     final BLSSignature signature = blindedBeaconBlock.getBlock().getBody().getRandaoReveal();
     when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
         .thenReturn(SafeFuture.completedFuture(Optional.of(blindedBeaconBlock)));
-    when(executionLayerBlockProductionManager.getCachedPayloadResult(UInt64.ONE))
-        .thenReturn(
-            Optional.of(
-                new ExecutionPayloadResult(
-                    mock(ExecutionPayloadContext.class),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.of(SafeFuture.completedFuture(executionPayloadValue)))));
     Response response = get(signature, ContentTypes.OCTET_STREAM);
-    assertThat(response.code()).isEqualTo(SC_OK);
-    assertThat(response.header(HEADER_CONSENSUS_VERSION))
-        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED)).isEqualTo(Boolean.toString(true));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
-        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertResponseWithHeaders(response, true);
     final BeaconBlock result =
         spec.getGenesisSchemaDefinitions()
             .getBlindedBeaconBlockSchema()
@@ -194,23 +155,8 @@ void shouldGetUnBlindedBlockContentPostDenebAsJson() throws IOException {
     final BLSSignature signature = blockContents.getBlock().getBody().getRandaoReveal();
     when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
         .thenReturn(SafeFuture.completedFuture(Optional.of(blockContents)));
-    when(executionLayerBlockProductionManager.getCachedPayloadResult(UInt64.ONE))
-        .thenReturn(
-            Optional.of(
-                new ExecutionPayloadResult(
-                    mock(ExecutionPayloadContext.class),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.of(SafeFuture.completedFuture(executionPayloadValue)))));
     Response response = get(signature, ContentTypes.JSON);
-    assertThat(response.code()).isEqualTo(SC_OK);
-    assertThat(response.header(HEADER_CONSENSUS_VERSION))
-        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED))
-        .isEqualTo(Boolean.toString(false));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
-        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertResponseWithHeaders(response, false);
     final String body = response.body().string();
     assertThat(body).isEqualTo(getExpectedBlockAsJson(specMilestone, false, true));
   }
@@ -222,23 +168,8 @@ void shouldGetUnBlindedBlockContentPostDenebAsSsz() throws IOException {
     final BLSSignature signature = blockContents.getBlock().getBody().getRandaoReveal();
     when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
         .thenReturn(SafeFuture.completedFuture(Optional.of(blockContents)));
-    when(executionLayerBlockProductionManager.getCachedPayloadResult(UInt64.ONE))
-        .thenReturn(
-            Optional.of(
-                new ExecutionPayloadResult(
-                    mock(ExecutionPayloadContext.class),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.of(SafeFuture.completedFuture(executionPayloadValue)))));
     Response response = get(signature, ContentTypes.OCTET_STREAM);
-    assertThat(response.code()).isEqualTo(SC_OK);
-    assertThat(response.header(HEADER_CONSENSUS_VERSION))
-        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED))
-        .isEqualTo(Boolean.toString(false));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
-        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertResponseWithHeaders(response, false);
     final BlockContents result =
         (BlockContents)
             spec.getGenesisSchemaDefinitions()
@@ -255,22 +186,8 @@ void shouldGetBlindedBlockContentPostDenebAsJson() throws IOException {
     final BLSSignature signature = blindedBlockContents.getBlock().getBody().getRandaoReveal();
     when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
         .thenReturn(SafeFuture.completedFuture(Optional.of(blindedBlockContents)));
-    when(executionLayerBlockProductionManager.getCachedPayloadResult(UInt64.ONE))
-        .thenReturn(
-            Optional.of(
-                new ExecutionPayloadResult(
-                    mock(ExecutionPayloadContext.class),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.of(SafeFuture.completedFuture(executionPayloadValue)))));
     Response response = get(signature, ContentTypes.JSON);
-    assertThat(response.code()).isEqualTo(SC_OK);
-    assertThat(response.header(HEADER_CONSENSUS_VERSION))
-        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED)).isEqualTo(Boolean.toString(true));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
-        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertResponseWithHeaders(response, true);
     final String body = response.body().string();
     assertThat(body).isEqualTo(getExpectedBlockAsJson(specMilestone, true, true));
   }
@@ -283,22 +200,8 @@ void shouldGetBlindedBlockContentPostDenebAsSsz() throws IOException {
     final BLSSignature signature = blindedBlockContents.getBlock().getBody().getRandaoReveal();
     when(validatorApiChannel.createUnsignedBlock(eq(UInt64.ONE), eq(signature), any()))
         .thenReturn(SafeFuture.completedFuture(Optional.of(blindedBlockContents)));
-    when(executionLayerBlockProductionManager.getCachedPayloadResult(UInt64.ONE))
-        .thenReturn(
-            Optional.of(
-                new ExecutionPayloadResult(
-                    mock(ExecutionPayloadContext.class),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.empty(),
-                    Optional.of(SafeFuture.completedFuture(executionPayloadValue)))));
     Response response = get(signature, ContentTypes.OCTET_STREAM);
-    assertThat(response.code()).isEqualTo(SC_OK);
-    assertThat(response.header(HEADER_CONSENSUS_VERSION))
-        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED)).isEqualTo(Boolean.toString(true));
-    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
-        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertResponseWithHeaders(response, true);
     final BlindedBlockContents result =
         (BlindedBlockContents)
             spec.getGenesisSchemaDefinitions()
@@ -378,4 +281,15 @@ private String getExpectedBlockAsJson(
     return Resources.toString(
         Resources.getResource(GetNewBlockV3IntegrationTest.class, fileName), UTF_8);
   }
+
+  private void assertResponseWithHeaders(Response response, boolean blinded) {
+    assertThat(response.code()).isEqualTo(SC_OK);
+    assertThat(response.header(HEADER_CONSENSUS_VERSION))
+        .isEqualTo(specMilestone.name().toLowerCase(Locale.ROOT));
+    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_BLINDED))
+        .isEqualTo(Boolean.toString(blinded));
+    assertThat(response.header(HEADER_EXECUTION_PAYLOAD_VALUE))
+        .isEqualTo(executionPayloadValue.toDecimalString());
+    assertThat(response.header(HEADER_CONSENSUS_BLOCK_VALUE)).isEqualTo(consensusBlockValueWei);
+  }
 }

data/beaconrestapi/src/integration-test/resources/tech/pegasys/teku/beaconrestapi/beacon/schema/ProduceBlockV3Response.json

@@ -1,7 +1,7 @@
 {
   "title" : "ProduceBlockV3Response",
   "type" : "object",
-  "required" : [ "version", "execution_payload_blinded", "execution_payload_value", "data" ],
+  "required" : [ "version", "execution_payload_blinded", "execution_payload_value", "consensus_block_value", "data" ],
   "properties" : {
     "version" : {
       "type" : "string",
@@ -16,6 +16,12 @@
       "example" : "1",
       "format" : "uint256"
     },
+    "consensus_block_value" : {
+      "type" : "string",
+      "description" : "unsigned 256 bit integer",
+      "example" : "1",
+      "format" : "uint256"
+    },
     "data" : {
       "title" : "Block",
       "type" : "object",