Add getBlobSidecars Beacon API #7237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,86 @@ | |||
| /* | |||
There was a problem hiding this comment.
I don't know but why do we need these schema classes given we use the jsonTypeDefinition from the SchemaDefinitions?
There was a problem hiding this comment.
Maybe required for swagger-ui?
There was a problem hiding this comment.
I probably could make it Bytes but there will be no size verification
There was a problem hiding this comment.
I'd better make Bytes48 and at least we will get one class instead of two
There was a problem hiding this comment.
My question actually is what are these schema objects under api/schema used for?
There was a problem hiding this comment.
Nice point, was able to remove it
| } | ||
|
|
||
| private static ResponseContentTypeDefinition<List<BlobSidecar>> getSszResponseType() { | ||
| OctetStreamResponseContentTypeDefinition.OctetStreamSerializer<List<BlobSidecar>> serializer = |
There was a problem hiding this comment.
GPT will get our jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds
getBlobSidecarsBeacon APIFixed Issue(s)
Fixes #6781
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog