Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waiting for ready comment on SSE channel to mark connection as ready #6600

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Waiting for ready comment on SSE channel to mark connection as ready #6600

merged 3 commits into from
Dec 14, 2022

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Dec 14, 2022 •
edited
Loading

PR Description

  • EventSubscriber now sends an SSE comment with "ready" to notify the client it is ready to send events
  • On ATs, we wait for "ready" comment on SSE channel before continuing

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

ajsutton
ajsutton approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to update the tests to expect the ready comment.

@lucassaldanha
Copy link
Member Author

LGTM. Just need to update the tests to expect the ready comment.

I did :(

@lucassaldanha lucassaldanha enabled auto-merge (squash) December 14, 2022 05:01
@lucassaldanha lucassaldanha merged commit 2eda229 into Consensys:master Dec 14, 2022
@lucassaldanha lucassaldanha deleted the fix-flaky-tests branch February 10, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucassaldanha @ajsutton