Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of validators checked during withdrawals lookup #6593

Merged
merged 9 commits into from
Dec 16, 2022

Conversation

lucassaldanha
Copy link
Member

PR Description

  • Adding MAX_VALIDATORS_PER_WITHDRAWALS_SWEEP to presets files and Capella SpecConfig
  • Updated get_expected_withdrawals and process_withdrawals to use MAX_VALIDATORS_PER_WITHDRAWALS_SWEEP

Fixed Issue(s)

fixes #6592

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@lucassaldanha lucassaldanha changed the title Limit number of validators checked during withdrawals lookup [DO NOT MERGE] Limit number of validators checked during withdrawals lookup Dec 13, 2022
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to get the minimal config fixed.

@ajsutton ajsutton marked this pull request as ready for review December 15, 2022 23:31
@ajsutton ajsutton changed the title [DO NOT MERGE] Limit number of validators checked during withdrawals lookup Limit number of validators checked during withdrawals lookup Dec 15, 2022
@ajsutton ajsutton merged commit 919a522 into Consensys:master Dec 16, 2022
@lucassaldanha lucassaldanha deleted the bound-validators-sweep branch February 10, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit number of validators checked during withdrawals lookup
3 participants