Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the wrapper around the c-kzg library #6530

Merged
merged 13 commits into from
Dec 1, 2022
Merged

Simplify the wrapper around the c-kzg library #6530

merged 13 commits into from
Dec 1, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Dec 1, 2022 •
edited
Loading

PR Description

  • a bit of simplification of our wrapper around the c-kzg library
  • removed javadoc of the interface because in my opinion the javadoc in the jc-kzg-4844 library is enough
  • removed one layer of abstraction (just one interface and implementation)
  • Added NOOP implenentation in case it is needed when initialising

Fixed Issue(s)

will help with #6382

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

zilm13
zilm13 reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

infrastructure/kzg/src/main/java/tech/pegasys/teku/kzg/KZGException.java Show resolved Hide resolved
infrastructure/kzg/src/main/java/tech/pegasys/teku/kzg/ckzg4844/CKZG4844.java Outdated Show resolved Hide resolved
infrastructure/kzg/src/main/java/tech/pegasys/teku/kzg/ckzg4844/CKZG4844.java Outdated Show resolved Hide resolved
infrastructure/kzg/src/main/java/tech/pegasys/teku/kzg/ckzg4844/CKZG4844.java Outdated Show resolved Hide resolved
infrastructure/kzg/src/test/java/tech/pegasys/teku/kzg/KZGTest.java Show resolved Hide resolved
zilm13
zilm13 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) December 1, 2022 16:45
@StefanBratanov StefanBratanov merged commit 5ee6d65 into Consensys:master Dec 1, 2022
@StefanBratanov StefanBratanov deleted the simplify_wrapper branch December 1, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @zilm13