Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining naming convention violations #5258

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

ajsutton
Copy link
Contributor

PR Description

Fix remaining naming convention violations and enable strict enforcement of Java naming convention via custom errorprone check. Thanks to @jtraglia for the error prone work.

Fixed Issue(s)

Fixes #1575 once and for all.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Enable strict enforcement of Java naming convention via custom errorprone check. Thanks to @jtraglia
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton merged commit 30b644e into Consensys:master Mar 30, 2022
@ajsutton ajsutton deleted the follow-naming-convention2 branch March 30, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adhere to Java Naming Conventions
2 participants