Fix a lot of naming convention violations #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing for the updated errorprone rules to come in so fixing problems. Note we suppress the errors for beacon rest API definition classes.
2 tasks
jtraglia
reviewed
Mar 30, 2022
Comment on lines
+74
to
86
| @Test | ||
| public void equals_shouldReturnTrue() { | ||
| final T state = randomState(); | ||
| final T stateCopy = (T) state.updated(__ -> {}); | ||
| final Object stateCopy = state.getSchema().createFromBackingNode(state.getBackingNode()); | ||
|
|
||
| assertThat(state == stateCopy).isFalse(); | ||
| assertThat(state).isEqualTo(stateCopy); | ||
| assertThat(state.hashCode()).isEqualTo(stateCopy.hashCode()); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| @Test | ||
| public void equals_shouldReturnFalse() { |
There was a problem hiding this comment.
Nice catch. I guess these weren't being tested before.
There was a problem hiding this comment.
Yeah I was pleased to catch that. They aren't particularly important tests but still nice to fix.
jtraglia
reviewed
Mar 30, 2022
| @@ -152,7 +152,7 @@ public SignedBlockAndState finalizeCurrentChain() { | |||
| saveBlock(newChainHead); | |||
| updateBestBlock(newChainHead); | |||
| } | |||
| final Checkpoint finalizedCheckpoint = newChainHead.getState().getFinalized_checkpoint(); | |||
| final Checkpoint finalizedCheckpoint = newChainHead.getState().getFinalizedCheckpoint(); | |||
There was a problem hiding this comment.
GitHub code scanning correctly pointed out that newChainHead could be null. But this is just a test fixture and those values are hardcoded, so it doesn't matter.
There was a problem hiding this comment.
Fortunately it has "Used in tests" and "Won't fix" options to make it be quiet. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Preparing for the updated errorprone rules to come in so fixing problems. Note we suppress the errors for beacon rest API definition classes.
Also fixes a few cases which violate the new
MathTargetTypecheck (Consensys/errorprone-checks#7).Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog