Remove ConstantsReader #4922
Merged
Remove ConstantsReader #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies Constants to manually load the remaining fields from a SpecConfig instance to ensure they're always in sync. Required moving Constants to the spec.config package alongside SpecConfig to get the module dependencies to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Modifies Constants to manually load the remaining fields from a SpecConfig instance to ensure they're always in sync (and there's only three fields from the spec now so no need for all the reflection magic).
Required moving Constants to the spec.config package alongside SpecConfig to get the module dependencies to work which caused quite a lot of noise.
Fixed Issue(s)
Documentation
documentationlabel to this PR if updates are required.Changelog