fix: private trie cache db with gc #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardolyn
previously approved these changes
Aug 30, 2021
GoQuorum Comments
ricardolyn
approved these changes
Aug 31, 2021
danielporto
pushed a commit
to danielporto/quorum
that referenced
this pull request
Sep 7, 2021
* fix: private trie cache db with gc * fix: commit * fix: use the right private root * contract implementation enforcement * fix merge * GoQ comments * Apply suggestions from code review GoQuorum Comments
baptiste-b-pegasys
added a commit
that referenced
this pull request
Oct 1, 2021
Bug found in the MPS, want to package this feature for both dual state and MPS. This reverts commit 614b212.
ricardolyn
pushed a commit
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't save the private trie DB at every commit.
Use the same way as the public trie DB, where data stored are optimized with cache and GC.