Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: add pod identity to workload identity #203

Merged
merged 1 commit into from
Sep 25, 2023
Merged

update: add pod identity to workload identity #203

merged 1 commit into from
Sep 25, 2023

Conversation

nowjean
Copy link
Contributor

@nowjean nowjean commented Aug 24, 2023

fix #202

@joshuafernandes joshuafernandes force-pushed the master branch 2 times, most recently from be7a62e to 3ed4fdd Compare September 25, 2023 02:36
@joshuafernandes
Copy link
Contributor

Hello @nowjean , thankyou for looking into this and for the PR :)

@joshuafernandes joshuafernandes self-requested a review September 25, 2023 10:22
joshuafernandes
joshuafernandes approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@joshuafernandes joshuafernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge and fix up the readme and move creation of the workload identity into the arm template it self

@joshuafernandes joshuafernandes merged commit b4336d2 into Consensys:master Sep 25, 2023
@nowjean nowjean mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuafernandes joshuafernandes joshuafernandes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Azure Workload Identity
2 participants
@nowjean @joshuafernandes