[OR-322] - Include Oracle JDBC driver in package #291
Conversation
-- use Oracle maven repo to downloand and package Oracle JDBC driver
|
|
-- use Oracle maven repo to downloand and package Oracle JDBC driver
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
| @@ -10,6 +10,7 @@ version.txt | |||
|
|
|||
| ### Gradle ### | |||
| .gradle | |||
| gradle.properties | |||
There was a problem hiding this comment.
Why is there a gradle.properties at the root of Orion to now ignore?
There was a problem hiding this comment.
gradle.properties is used by gradle to read personal project properties which we don't want to commit to git (in our case Oracle maven user and password). Hence, it is in ignore list.
Signed-off-by: Usman Saleem <usman@usmans.info>
| @@ -0,0 +1,16 @@ | |||
| # Oracle Maven Access | |||
| * Orion bundles Oracle JDBC driver which is downloaded from Oracle Maven repository by Gradle. | |||
| * You need to provide your Oracle account credentials to access Oracle Maven repository. | |||
There was a problem hiding this comment.
The reading of this line suggests this PR is introducing a dependency on having a OTN account to build Orion, is that correct?
There was a problem hiding this comment.
@CjHare It is partially correct now that I am re-reading it. The Orion would still build without Oracle JDBC if we don't create project properties. It needs to be re-worded as Orion can optionally bundle JDBC driver...
There was a problem hiding this comment.
but your point is correct, this PR is introducing a dependency on having an Oracle account in order to bundle Oracle JDBC driver
-- use Oracle maven repo to downloand and package Oracle JDBC driver