This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Adding Dockerfile and README instructions #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Apr 17, 2018
| **Starting the container:** | ||
| ``` | ||
| $ docker run -d -p 8080:8080 -v data:/data orion |
There was a problem hiding this comment.
Do you want to map 8888 as well?
There was a problem hiding this comment.
I guess it depends on what you want one wants. This was just an example and I tried to keep it simple. I can add it if you think it is important.
There was a problem hiding this comment.
I don't have an opinion yet. Easy to add later, and if the point is to get started, this is probably fine.
atoulme
approved these changes
Apr 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Dockerfile and README instructions on how to run Orion in a docker container.