Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multi-stage builds to unzip and copy jars #118

Merged
merged 28 commits into from
Dec 2, 2024

Conversation

bradbown
Copy link
Contributor

@bradbown bradbown commented Sep 30, 2024

This PR implements issue(s) #134

Multi stage reduces size of image by 110MB.
Removes unnecessary libs depending on architecture.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

Copy link

github-actions bot commented Sep 30, 2024

Delta Summary - Kotlin Code Coverage

Generated on: 10/01/2024 - 12:55
Description Previous Current Delta
Coverage date: 10/01/2024 - 12:55 10/01/2024 - 12:55
Tag: 588_11125691323 588_11125691323
Line coverage: 27.3% 27.3% 0.0%
Covered lines: 25673 25673 0
Coverable lines: 93723 93723 0
Total lines: 132974 132974 0
Branch coverage: 10.4% 10.4% 0.0%
Covered branches: 5529 5529 0
Total branches: 52680 52680 0
Method coverage: Feature is only available for sponsors

@bradbown bradbown requested review from a team September 30, 2024 17:41
coordinator/Dockerfile Outdated Show resolved Hide resolved
@bradbown bradbown force-pushed the docker-coordinator-image-size-reduction branch 2 times, most recently from 39ebe00 to 509c849 Compare October 1, 2024 09:55
coordinator/Dockerfile Outdated Show resolved Hide resolved
coordinator/Dockerfile Outdated Show resolved Hide resolved
coordinator/Dockerfile Outdated Show resolved Hide resolved
coordinator/Dockerfile Outdated Show resolved Hide resolved
coordinator/Dockerfile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.16%. Comparing base (c4c3bfd) to head (27cef5d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #118      +/-   ##
============================================
- Coverage     70.20%   70.16%   -0.05%     
+ Complexity     1072     1070       -2     
============================================
  Files           306      305       -1     
  Lines         12322    12331       +9     
  Branches       1178     1178              
============================================
+ Hits           8651     8652       +1     
- Misses         3179     3202      +23     
+ Partials        492      477      -15     
Flag Coverage Δ *Carryforward flag
hardhat 98.69% <ø> (-0.01%) ⬇️ Carriedforward from 0179aa7
kotlin 67.86% <ø> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 11 files with indirect coverage changes

@bradbown bradbown force-pushed the docker-coordinator-image-size-reduction branch from d472ac4 to da905b6 Compare October 10, 2024 11:31
coordinator/Dockerfile Outdated Show resolved Hide resolved
coordinator/Dockerfile Outdated Show resolved Hide resolved
@bradbown bradbown had a problem deploying to docker-build-and-e2e October 15, 2024 10:59 — with GitHub Actions Failure
coordinator/Dockerfile Outdated Show resolved Hide resolved
@jonesho jonesho force-pushed the docker-coordinator-image-size-reduction branch from a63e658 to 1939569 Compare November 6, 2024 08:41
@jonesho jonesho temporarily deployed to docker-build-and-e2e November 6, 2024 08:41 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e November 6, 2024 10:39 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the docker-coordinator-image-size-reduction branch from b2ef74c to c6d5449 Compare November 19, 2024 05:32
@jonesho jonesho temporarily deployed to docker-build-and-e2e November 19, 2024 05:32 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e November 19, 2024 05:45 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the docker-coordinator-image-size-reduction branch from 7efc0c9 to bf1b194 Compare November 20, 2024 07:18
@jonesho jonesho temporarily deployed to docker-build-and-e2e November 20, 2024 07:18 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the docker-coordinator-image-size-reduction branch from 30df9bd to eb11af2 Compare November 25, 2024 06:25
@jonesho jonesho temporarily deployed to docker-build-and-e2e November 25, 2024 06:25 — with GitHub Actions Inactive
@jonesho jonesho requested review from jpnovais and removed request for jpnovais November 26, 2024 03:37
@jonesho jonesho requested review from jpnovais and removed request for jpnovais December 2, 2024 08:53
@jonesho jonesho temporarily deployed to docker-build-and-e2e December 2, 2024 08:54 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e December 2, 2024 13:42 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e December 2, 2024 15:06 — with GitHub Actions Inactive
@jonesho jonesho merged commit bca27b1 into main Dec 2, 2024
23 checks passed
@jonesho jonesho deleted the docker-coordinator-image-size-reduction branch December 2, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants