-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multi-stage builds to unzip and copy jars #118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delta Summary - Kotlin Code Coverage
|
jonesho
reviewed
Sep 30, 2024
bradbown
force-pushed
the
docker-coordinator-image-size-reduction
branch
2 times, most recently
from
October 1, 2024 09:55
39ebe00
to
509c849
Compare
jonesho
reviewed
Oct 2, 2024
jonesho
reviewed
Oct 2, 2024
jonesho
reviewed
Oct 2, 2024
jonesho
reviewed
Oct 2, 2024
jonesho
reviewed
Oct 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
============================================
- Coverage 70.20% 70.16% -0.05%
+ Complexity 1072 1070 -2
============================================
Files 306 305 -1
Lines 12322 12331 +9
Branches 1178 1178
============================================
+ Hits 8651 8652 +1
- Misses 3179 3202 +23
+ Partials 492 477 -15
*This pull request uses carry forward flags. Click here to find out more. |
bradbown
force-pushed
the
docker-coordinator-image-size-reduction
branch
from
October 10, 2024 11:31
d472ac4
to
da905b6
Compare
jonesho
reviewed
Oct 14, 2024
jonesho
reviewed
Oct 14, 2024
bradbown
had a problem deploying
to
docker-build-and-e2e
October 15, 2024 10:59 — with
GitHub Actions
Failure
jonesho
reviewed
Oct 15, 2024
jonesho
force-pushed
the
docker-coordinator-image-size-reduction
branch
from
November 6, 2024 08:41
a63e658
to
1939569
Compare
jonesho
temporarily deployed
to
docker-build-and-e2e
November 6, 2024 08:41 — with
GitHub Actions
Inactive
jonesho
temporarily deployed
to
docker-build-and-e2e
November 6, 2024 10:39 — with
GitHub Actions
Inactive
jonesho
force-pushed
the
docker-coordinator-image-size-reduction
branch
from
November 19, 2024 05:32
b2ef74c
to
c6d5449
Compare
jonesho
temporarily deployed
to
docker-build-and-e2e
November 19, 2024 05:32 — with
GitHub Actions
Inactive
jonesho
temporarily deployed
to
docker-build-and-e2e
November 19, 2024 05:45 — with
GitHub Actions
Inactive
5 tasks
jonesho
force-pushed
the
docker-coordinator-image-size-reduction
branch
from
November 20, 2024 07:18
7efc0c9
to
bf1b194
Compare
jonesho
temporarily deployed
to
docker-build-and-e2e
November 20, 2024 07:18 — with
GitHub Actions
Inactive
jonesho
force-pushed
the
docker-coordinator-image-size-reduction
branch
from
November 25, 2024 06:25
30df9bd
to
eb11af2
Compare
jonesho
temporarily deployed
to
docker-build-and-e2e
November 25, 2024 06:25 — with
GitHub Actions
Inactive
jpnovais
reviewed
Nov 25, 2024
jonesho
temporarily deployed
to
docker-build-and-e2e
December 2, 2024 08:54 — with
GitHub Actions
Inactive
jpnovais
approved these changes
Dec 2, 2024
jonesho
temporarily deployed
to
docker-build-and-e2e
December 2, 2024 13:42 — with
GitHub Actions
Inactive
jonesho
temporarily deployed
to
docker-build-and-e2e
December 2, 2024 15:06 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #134
Multi stage reduces size of image by 110MB.
Removes unnecessary libs depending on architecture.
Checklist