Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose set finalized and safe block in plugin api BlockchainService #43

Closed

Conversation

usmansaleem
Copy link

Expose set finalized and set safe block methods in Blockchain service in the plugin api.

…vice

Signed-off-by: Usman Saleem <usman@usmans.info>
Copy link

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fab-10
Copy link
Collaborator

fab-10 commented Jul 26, 2024

Since the same PR is ready on upstream Besu, there is no need to redo it here, so please do not merge.
You usually make a PR here only when you are not yet sure if it makes sense on upstream Besu, or it is a PoC that needs to be refined.

@usmansaleem
Copy link
Author

Closing due to hyperledger#7382

@usmansaleem usmansaleem deleted the blockchain_plugin_finalized branch July 30, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants