-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK Function Call API + main class for SDK #91
Conversation
Signed-off-by: Peter Robinson <drinkcoffee@eml.cc>
Signed-off-by: Peter Robinson <drinkcoffee@eml.cc>
Signed-off-by: Peter Robinson <drinkcoffee@eml.cc>
Signed-off-by: Peter Robinson <drinkcoffee@eml.cc>
When considering this PR, an important class to consider is: CrosschainProtocols. Is the API the approach that everyone is happy with: https://github.com/ConsenSys/gpact/pull/91/files#diff-50addbac16a7bfb7c1b8d7e0fb74f45176a6c25ce8cc7573639581643f4a72ac |
Another thing which I have considered is moving all implementation / non API packages into a sub-package "internal". That is the packages from change as shown below. The idea would be to make it obvious that the classes should not be used directly, even if a constructor, method or field was public. In this PR / current If we had "internal" |
Signed-off-by: Peter Robinson <drinkcoffee@eml.cc>
.../write/java/src/main/java/net/consensys/gpact/examples/gpact/write/GpactCrosschainWrite.java
Outdated
Show resolved
Hide resolved
examples/gpact/trade/java/src/main/java/net/consensys/gpact/examples/gpact/trade/Main.java
Outdated
Show resolved
Hide resolved
sdk/java/src/main/java/net/consensys/gpact/CrosschainProtocols.java
Outdated
Show resolved
Hide resolved
sdk/java/src/main/java/net/consensys/gpact/CrosschainProtocols.java
Outdated
Show resolved
Hide resolved
sdk/java/src/main/java/net/consensys/gpact/CrosschainProtocols.java
Outdated
Show resolved
Hide resolved
sdk/java/src/main/java/net/consensys/gpact/functioncall/CrossControlManagerGroup.java
Show resolved
Hide resolved
Signed-off-by: Peter Robinson <drinkcoffee@eml.cc>
Signed-off-by: Peter Robinson <drinkcoffee@eml.cc>
Signed-off-by: Peter Robinson <drinkcoffee@eml.cc>
This pull request creates a new entry point class for the SDK: net.consensys.gpact.CrosschainProtocols The idea is that this is the central point class from which all functionality can be accessed. The class allows for registration of new implementations from third party vendors. At present, this class only supports the function call API. Messaging layer classes will be added in a separate PR.
This pull request also creates an API for the function call layer. The example code access functionality using CrosschainProtocols and this API only: no access to implementation classes is needed. As a result of the common API, how to execute a crosschain transaction with the GPACT and SFC protocols has changed slightly. These changes are reflected in the example code.