Add Java compilation to initial checks #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the initial checks during the Java SDK build and test was to run solFormat and spotlessCheck. Adding in a compile takes almost no extra time. This is achieved by running: ./gradlew build -x test . This runs everything in the build process, except running the test code.
The advantage of doing this is finding out about compilation failures that IDEs might not be highlighting earlier in the build process.
There is an additional Circle CI target which only runs the ./gradlew build -x test . Unfortunately, prior to running this Web3J needs to be built and Solidity needs to be installed. This results in the overall build being 1 1/2 minutes longer. Hence, this code is available for possible future use, but is not currently run.