Skip to content

fix: VerifyProof comment to reflect in-circuit behavior #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

fix: VerifyProof comment to reflect in-circuit behavior #1641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions std/accumulator/merkle/verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,12 @@ func nodeSum(api frontend.API, h hash.FieldHasher, a, b frontend.Variable) front
return res
}

// VerifyProof takes a Merkle root, a proofSet, and a proofIndex and returns
// true if the first element of the proof set is a leaf of data in the Merkle
// root. False is returned if the proof set or Merkle root is nil, and if
// 'numLeaves' equals 0.
// VerifyProof encodes constraints that verify inclusion of a leaf at the given
// index into the Merkle root stored in mp.RootHash, using the authentication
// path stored in mp.Path. The argument leaf is the leaf index (little-endian
// bit order). The actual leaf value must be provided as mp.Path[0]. This
// method does not return a value; it asserts equality of the recomputed root
// and mp.RootHash via constraints.
func (mp *MerkleProof) VerifyProof(api frontend.API, h hash.FieldHasher, leaf frontend.Variable) {

depth := len(mp.Path) - 1
Expand Down