chore: remove unused min func #1617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Go 1.21 adds built-in functions min and max. https://tip.golang.org/doc/go1.21
Therefore, we can directly remove our own implementations and use the built-in function with the same names.
Fixes # (issue)
Type of change
How has this been tested?
How has this been benchmarked?
Checklist:
golangci-lintdoes not output errors locallyNote
Replaces x/exp slices/constraints with stdlib slices/cmp, removes a local min helper and the x/exp dependency, and adds an empty-terms guard plus slices.Max in multivariate quotient sizing.
golang.org/x/expfromgo.modand purge related entries fromgo.sum.golang.org/x/exp/sliceswith standardslicesinstd/fiat-shamir/transcript.goandstd/recursion/wrapped_hash.go.golang.org/x/exp/constraintswith standardcmpand update generic bounds instd/math/emulated/field.go.minhelper fromstd/compress/io.go.std/math/emulated/field_mul.go:mv.Termsis empty inpolyMvEvalQuoSize.slices.MaxforquoSizecomputation.Written by Cursor Bugbot for commit fe63ab8. This will update automatically on new commits. Configure here.