Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicit IO methods in interfaces #1266

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Sep 3, 2024

Description

Previously the Groth16 interfaces referred to groth16Object. As it wasn't exported, then it wasn't obvious that the interfaces implement the IO methods. I made the methods now explicit for better reference.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added consolidate strengthen an existing feature doc labels Sep 3, 2024
@ivokub ivokub requested a review from gbotrel September 3, 2024 12:24
@ivokub ivokub self-assigned this Sep 3, 2024
@ivokub ivokub merged commit 8b00519 into master Sep 3, 2024
6 checks passed
@ivokub ivokub deleted the chore/io-interfaces branch September 3, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants