This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Use Java 17 and upgrade Azure and web3j libraries#530
Merged
usmansaleem merged 11 commits intoConsensys:masterfrom Oct 17, 2023
Merged
Use Java 17 and upgrade Azure and web3j libraries#530usmansaleem merged 11 commits intoConsensys:masterfrom
usmansaleem merged 11 commits intoConsensys:masterfrom
Conversation
-- suppress CVE for azure-identity 1.10.2 to 1.10.9 as it is only applicable on 1.10.1 and lower.
-- Update spotless plugin -- Fix javadoc -- Update circleci -- Update dockerfile
usmansaleem
changed the title
siladu
reviewed
Oct 16, 2023
| ### Bugs Fixed | ||
| - Update grpc to version 1.57.2 to fix CVE-2023-33953 | ||
| - Update Azure libraries to fix CVE-2023-36415 | ||
| - Update okhttp logging interceptor version to fix CVE-2023-0833 |
Contributor
There was a problem hiding this comment.
Do we need to mention web3j in here too?
Contributor
Author
There was a problem hiding this comment.
we might mention web3j in "features added" ? as we are overriding logging-interceptor anyways ...
| com.squareup.okhttp3:logging-interceptor:4.9.0 // CVE-2023-0833 | ||
| \--- org.web3j:core:4.10.2 | ||
| */ | ||
| dependency 'com.squareup.okhttp3:logging-interceptor:4.11.0' |
Contributor
There was a problem hiding this comment.
This is still necessary despite web3j upgrade?
Contributor
Author
There was a problem hiding this comment.
unfortunately yes ... the fixed version of this library is available as part of web3j latest version ... however, web3j latest version is not compatible with ethsigner anymore due to dependency on signers library. (one of the exception package has changed that signers module is using from web3j).
usmansaleem
added
the
TeamGroot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog