Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Updating latest Besu release to use with AT#361

Merged
usmansaleem merged 9 commits intoConsensys:masterfrom
usmansaleem:besu_distro
Mar 12, 2021
Merged

Updating latest Besu release to use with AT#361
usmansaleem merged 9 commits intoConsensys:masterfrom
usmansaleem:besu_distro

Conversation

@usmansaleem
Copy link
Copy Markdown
Contributor

@usmansaleem usmansaleem commented Mar 9, 2021

-- add support for gzip compression

 -- Also moving to tag based release in build script

Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem added the TeamGroot Identifies a given issue is assigned to the Groot Team label Mar 9, 2021
@usmansaleem usmansaleem requested review from jframe and rain-on March 9, 2021 06:47
Signed-off-by: Usman Saleem <usman@usmans.info>

# Conflicts:
#	gradle.properties
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem marked this pull request as ready for review March 11, 2021 07:10
Copy link
Copy Markdown
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rain-on rain-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one ultra-minor issue - but would love to get some investigation into WHY the compression is an issue.

}
}

public static SignerResponse<JsonRpcErrorResponse> fromWeb3JErrorResponse(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web3j (lowercase j?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

 -- add debug headers output

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem merged commit 866cf3a into Consensys:master Mar 12, 2021
@usmansaleem usmansaleem deleted the besu_distro branch March 12, 2021 05:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

TeamGroot Identifies a given issue is assigned to the Groot Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants