feat(upload): added upload functionality#47
Conversation
|
One small thing I couldn't figure out quickly was how to prevent all inputs from being uppercase -- this is confusing (e.g. JSON appears to be uppercase, but on retrieval is lowercase).. |
MaxBlaushild
left a comment
MaxBlaushild
left a comment
There was a problem hiding this comment.
Code looks great! Just two questions about requirements, then looks good to me
|
|
||
| handleSubmit = (event) => { | ||
| event.preventDefault(); | ||
| const file = JSON.parse(this.state.file); |
There was a problem hiding this comment.
Dispatch an upload error here if file is un-parsable? Most people (myself included) suck at hand rolling json so I imagine this will fail a lot
There was a problem hiding this comment.
Done, moved validation further downstream to the action.
| /> | ||
|
|
||
| <Typography variant='body1' className={classes.paragraph}> | ||
| <b>Metadata</b> should be text that people will use to find your data. What will be useful to query later? |
There was a problem hiding this comment.
We're very strongly encouraging metadata to be stringified JSON now. Would be nice to update the copy/add a check to ensure that the metadata is parseable JSON.
There was a problem hiding this comment.
Done, included the sample metadata and a link to the guidelines.
|
@MaxBlaushild only thing left is my previous comment about how to stop inputs from being forced uppercase.. |
|
@MaxBlaushild isolated the uppercase issue as the linnia-brand ThemeProvider font Heavitas, which only has uppercase typeface. This threw me off as I was looking for uppercase CSS styling! Thoughts on changing the font for inputs to allow lowercase? |
|
@daniel-lanciana Aha! That's probably something we should have noticed sooner 😅
|
|
@MaxBlaushild added a global CSS style for textarea inputs to use 'Raleway' instead. |
|
Thanks Daniel! Looks good to me |
godfreyhobbs
left a comment
godfreyhobbs
left a comment
There was a problem hiding this comment.
@daniel-lanciana thanks for taking an interesting with our project. Unfortunately, this pull request does not align with our long-term goals. Based on our user's feedback the stow-box is too complex with too many files. The stow box should be a very simple start kit that can be quickly grokked in full.
Therefore we want to remove functionality rather than add functionality.
I suggest making this a new repo that can be an advanced sample stow application.
Let me know if you have any questions.
4 participants
Based on consensys.github.io/linnia-faucet (plus some general refactoring/cleanup).