This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Set maxBuffer to avoid ENOBUFS error message
#3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CruzMolina
approved these changes
Jul 1, 2020
Contributor
CruzMolina
left a comment
CruzMolina
left a comment
There was a problem hiding this comment.
Sweeeeet, thanks @chmanie !
gnidan
approved these changes
Jul 1, 2020
Contributor
gnidan
left a comment
gnidan
left a comment
There was a problem hiding this comment.
Looks good to me, too! Thanks for this!
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From version 12 on, node doesn't set a very high limit for
execSync'smaxBufferanymore. So we have to define that limit ourselves to avoid running into an ENOBUFS error for large contract suites.See nodejs/node#23027 and 180359b
To see that error message in a real-world project see https://app.circleci.com/pipelines/github/JoinColony/colonyNetwork/2377/workflows/eca45a24-a95a-4bad-8370-153e673cbb75/jobs/12639