This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Update to TestRPC v6.0.1 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamincburns
commented
Nov 3, 2017
| return | ||
| } | ||
|
|
||
| var state = result ? result : server.provider.manager.state; |
There was a problem hiding this comment.
This is a small workaround to an issue I accidentally introduced during the 6.x dev cycle (server callback isn't passed the state object anymore). With the way this is written fixing the problem won't break ganache.
I was dumb and released ganache-core before I found this issue (will test better next time), so rather than pushing out yet another release, I just created this workaround. Will fix the issue in the next ganache-core release.
There was a problem hiding this comment.
👍 Thanks for the writeup!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just what's on the label.