Skip to content

check --files / stats: invalid glob syntax is silently dropped #38

Description

@Connorrmcd6

Summary

Follow-up to #30, which fixed zero-match globs in suggest. Invalid glob syntax is still silently discarded:

  • surf-cli/src/check.rs:89--files patterns: .filter_map(|p| glob::Pattern::new(p).ok()). A bad pattern silently changes the check's scope (claim set widens or narrows with no signal).
  • surf-cli/src/stats.rs:84 — same for the surf.toml hub globs; a bad pattern silently excludes hubs from the metrics.

What

Fail with the offending pattern and the parse error instead of filter_map(.ok()).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdxDeveloper experience / CLI ergonomics

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions