[pull] dev from KelvinTegelaar:dev #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull bot
added a commit
that referenced
this pull request
Feb 27, 2024
[pull] master from KelvinTegelaar:master
Feat: Add QuarantineReleaseRequests alert for handling quarantine release requests
Refactored logic to correctly process DMARC records for each domain, ensuring only one correct DMARC record exists per domain. Added detailed logging, improved detection and deletion of incorrect records, and prevented unnecessary record creation when a valid DMARC record is already present.
Enhanced the handling of JSON parsing in the raw response by wrapping Test-Json in a try/catch block to prevent errors from breaking execution. Also replaced Select-Object with a PSCustomObject for more explicit property assignment.
Fix PWPush Pro account dropdown not populating
Improve tenant filtering in audit log rules
Set a default User-Agent header including the CIPP version for both GET and POST Graph API requests. The CIPP version is now stored globally in profile.ps1. Also, removed hardcoded User-Agent from Invoke-CIPPStandardAddDMARCToMOERA to use the new default behavior.
Ensures the Package property from existing templates is retained when updating or creating templates in both New-CIPPTemplateRun and Import-CommunityTemplate. This improves consistency and data integrity for template management.
Introduces SHA hash comparison for Conditional Access, Intune Compliance, and Intune Protection policy templates. Templates are only updated or created if the policy content has changed, preventing unnecessary overwrites and improving efficiency.
Improved the template creation process for Conditional Access, Intune Configuration, Compliance, and Protection policies by adding bulk Graph API requests, preloading users/groups, and ensuring more robust handling of existing templates. Added 'Source' and 'GUID' properties to template entities, improved logging, and updated return values for better feedback and consistency.
$null returns from activity functions cause errors in Wait-ActivityFunction
Updated Push-AuditLogTenantDownload.ps1 to use Add-Member with -Force for CippStatus and Error property assignments, ensuring properties are set correctly. Improved Start-ExtensionOrchestrator.ps1 to check for non-empty ExtensionConfig before validating JSON, preventing errors when config is null or empty.
Added support for reserved application names ('none', 'All', 'Office365', 'MicrosoftAdminPortals') when validating includeApplications and excludeApplications in New-CIPPCAPolicy. This ensures these reserved names are accepted even if not present in the service principals list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )